Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos: Use correct application name #786

Merged
merged 1 commit into from
Nov 20, 2019
Merged

macos: Use correct application name #786

merged 1 commit into from
Nov 20, 2019

Conversation

philippem
Copy link
Contributor

fixes #724

  • generated DS_Store for dmg was referencing Bitcoin-Qt instead
    of the locally built application Elements-Qt

image

@philippem
macos: Use correct application name
60ea625 
fixes ElementsProject#724
- ds_store was referencing Bitcoin-Qt instead
of built application Elements-Qt
@instagibbs
Copy link
Collaborator

Oh even simpler than I thought. Thanks!

utACK

@instagibbs instagibbs merged commit 60ea625 into ElementsProject:master Nov 20, 2019
instagibbs added a commit that referenced this pull request Nov 20, 2019
@instagibbs
Merge #786: macos: Use correct application name
fe27ef8 
60ea625 macos: Use correct application name (Philippe McLean)

Pull request description:

  fixes #724
  - generated DS_Store for dmg was referencing Bitcoin-Qt instead
  of the locally built application Elements-Qt

  ![image](https://user-images.githubusercontent.com/565792/69210165-b9085480-0b0e-11ea-80f5-6acef74d6929.png)

Tree-SHA512: d526b3ff1962e6c968b42ee77d9fb659bef4714195b2fb2dccfdac6443ed33789bc6d9f2edf7803dc78b93b29b5033b5e44811c7e94a3acea880043c12f1a89d
@philippem philippem deleted the macos_installer_elements_icon branch December 11, 2019 17:29
@instagibbs instagibbs added the needs port Needs backport to a different branch label Dec 11, 2019
@instagibbs instagibbs mentioned this pull request Dec 11, 2019
Merged
@stevenroose stevenroose mentioned this pull request Dec 12, 2019
Merged
instagibbs added a commit that referenced this pull request Dec 12, 2019
@instagibbs
Merge #798: [0.18 backport] macos: Use correct application name
169940c 
192620c macos: Use correct application name (Philippe McLean)

Pull request description:

  Backport of #786.

Tree-SHA512: e52f8ee135d897bed1c88c40e2a165303691c2db01d4cc9b1e2e9402293267ab5152775a839c08556508f66d1ce1471415349f2a1d2e99271ba3e84f6838e881
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 9, 2020
@apoelstra
Merge fe27ef8 into merged_master (Elements PR ElementsProject#786)
45b553a
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 10, 2020
@apoelstra
Merge fe27ef8 into merged_master (Elements PR ElementsProject#786)
6d08089
stevenroose pushed a commit that referenced this pull request Mar 16, 2021
@apoelstra
Merge fe27ef8 into merged_master (Elements PR #786)
cc8547e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs port Needs backport to a different branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mac Installer alignment is off
2 participants
@philippem @instagibbs